Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 680323002: Revert of Partially convert geolocation IPC to Mojo. (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, mkwst+moarreviews-ipc_chromium.org, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, vkuzkokov, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Partially convert geolocation IPC to Mojo. (patchset #16 id:360001 of https://codereview.chromium.org/628773003/) Reason for revert: Made inspector/geolocation-emulation-tests.html layout test crash on all platforms Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fgeolocation-emulation-tests.html Chromium revisions range: https://chromium.googlesource.com/chromium/src/+log/a772ed62ff0641df984feffe977b1545e94d53f1..5a5999ebee2d83c5a8dc72b3c6035fd803fdf90d?pretty=fuller Original issue's description: > Partially convert geolocation IPC to Mojo. > > This CL converts the non-permissions-related geolocation IPC to Mojo. The Mojo > GeolocationService interface allows clients to observe location updates. In > //content, the service and its client connect on a per-frame basis, eliminating > the need for the tracking of multiple frames that GeolocationDispatcherHost had > previously been doing. To handle the fact that geolocation updates can be > paused and resumed at per-WebContents granularity, we introduce a > GeolocationServiceContext class, which is used to scope the granularity of > pauses and resumes. > > Currently, GeolocationDispatcherHost still handles permissions-related > geolocation IPC. This IPC will be moved to Mojo once there is resolution on > what the right model for handling permissions there is. > > BUG=420497 > TEST=Go to maps.google.com, allow location tracking, and check that your > location is correctly pinpointed on the map. > > Committed: https://crrev.com/28e88081438dc08b06d5f05cfdd980c407db1638 > Cr-Commit-Position: refs/heads/master@{#301604} TBR=qsr@chromium.org,mvanouwerkerk@chromium.org,timvolodine@chromium.org,brettw@chromium.org,creis@chromium.org,tsepez@chromium.org,aa@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=420497 Committed: https://crrev.com/f9b12ff57fc7491e9ccaa6db69c893307bd1fee1 Cr-Commit-Position: refs/heads/master@{#301629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -569 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +1 line, -26 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.h View 4 chunks +39 lines, -8 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.cc View 5 chunks +160 lines, -1 line 0 comments Download
D content/browser/geolocation/geolocation_service_context.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/geolocation/geolocation_service_context.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/geolocation/geolocation_service_impl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/geolocation/geolocation_service_impl.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +4 lines, -12 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/geolocation_messages.h View 2 chunks +19 lines, -0 lines 0 comments Download
D content/common/geolocation_service.mojom View 1 chunk +0 lines, -21 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_common_mojo_bindings.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/common/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D content/public/common/mojo_geoposition.mojom View 1 chunk +0 lines, -58 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/geolocation_dispatcher.h View 3 chunks +6 lines, -9 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 5 chunks +38 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
Created Revert of Partially convert geolocation IPC to Mojo.
6 years, 1 month ago (2014-10-28 13:26:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680323002/1
6 years, 1 month ago (2014-10-28 13:27:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 13:27:49 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f9b12ff57fc7491e9ccaa6db69c893307bd1fee1 Cr-Commit-Position: refs/heads/master@{#301629}
6 years, 1 month ago (2014-10-28 13:28:31 UTC) #4
blundell
6 years, 1 month ago (2014-10-28 15:06:15 UTC) #5
Message was sent while issue was closed.
lgtm

d'oh! I even ran a bunch of geolocation layout tests locally, but didn't see
this one.

Powered by Google App Engine
This is Rietveld 408576698