Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 680323002: Revert of Partially convert geolocation IPC to Mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index e2c79ace1ed67e383e8a9158684260e3c85a491c..50b34994e4d1fe59c60aee4e436cb0872b6a591e 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -24,7 +24,6 @@
#include "content/browser/frame_host/render_frame_host_delegate.h"
#include "content/browser/frame_host/render_frame_proxy_host.h"
#include "content/browser/frame_host/render_widget_host_view_child_frame.h"
-#include "content/browser/geolocation/geolocation_service_context.h"
#include "content/browser/renderer_host/input/input_router.h"
#include "content/browser/renderer_host/input/timeout_monitor.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
@@ -211,6 +210,7 @@
}
SetUpMojoIfNeeded();
+
swapout_event_monitor_timeout_.reset(new TimeoutMonitor(base::Bind(
&RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr())));
}
@@ -1220,21 +1220,6 @@
}
#endif
-void RenderFrameHostImpl::RegisterMojoServices() {
- GeolocationServiceContext* geolocation_service_context =
- delegate_ ? delegate_->GetGeolocationServiceContext() : NULL;
- if (geolocation_service_context) {
- // TODO(creis): Bind process ID here so that GeolocationServiceImpl
- // can perform permissions checks once site isolation is complete.
- // crbug.com/426384
- GetServiceRegistry()->AddService<GeolocationService>(
- base::Bind(&GeolocationServiceContext::CreateService,
- base::Unretained(geolocation_service_context),
- base::Bind(&RenderFrameHostImpl::DidUseGeolocationPermission,
- base::Unretained(this))));
- }
-}
-
void RenderFrameHostImpl::SetState(RenderFrameHostImplState rfh_state) {
// Only main frames should be swapped out and retained inside a proxy host.
if (rfh_state == STATE_SWAPPED_OUT)
@@ -1460,7 +1445,6 @@
if (!GetProcess()->GetServiceRegistry())
return;
- RegisterMojoServices();
RenderFrameSetupPtr setup;
GetProcess()->GetServiceRegistry()->ConnectToRemoteService(&setup);
mojo::ServiceProviderPtr service_provider;
@@ -1648,13 +1632,4 @@
navigations_suspended_ = false;
}
-void RenderFrameHostImpl::DidUseGeolocationPermission() {
- RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
- GetContentClient()->browser()->RegisterPermissionUsage(
- PERMISSION_GEOLOCATION,
- delegate_->GetAsWebContents(),
- GetLastCommittedURL().GetOrigin(),
- top_frame->GetLastCommittedURL().GetOrigin());
-}
-
} // namespace content
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/geolocation/geolocation_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698