Never fire popstate event when navigating between documents

Never fire popstate event when navigating between documents

The specification says to only fire popstate events when the document's
"latest entry" isn't the session history entry being navigated to. This
can be the case when navigating between documents (when skipping history
entries, e.g. using history.go(-2)), but this patch simply disables
popstate entirely when navigating between documents.

The resulting behavior matches that of Firefox and MSIE.

BUG=400427
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184628

[Jens Widell, 2014-10-29 13:20:03]

jl@opera.com changed reviewers:
+ arv@chromium.org

[Jens Widell, 2014-10-29 13:20:03]

PTAL

I've filed a bug to have the spec updated to match this:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27188

[arv (Not doing code reviews), 2014-10-29 15:15:46]

LGTM

I'm not an OWNER so someone else will need to review this too.

[Jens Widell, 2014-10-29 15:35:18]

On 2014/10/29 15:15:46, arv wrote:
> LGTM
> 
> I'm not an OWNER so someone else will need to review this too.

Thanks! Technically you are OWNER (core/OWNERS), but I guess you mean someone
from core/loader/OWNERS?

[Jens Widell, 2014-10-29 20:24:02]

jl@opera.com changed reviewers:
+ japhet@chromium.org

[Jens Widell, 2014-10-29 20:24:02]

japhet@: Could you take a look?

[arv (Not doing code reviews), 2014-10-29 23:01:06]

Oh, I didn't know that I was in core/OWNERS.

On Wed, Oct 29, 2014 at 4:35 PM, <jl@opera.com> wrote:

> On 2014/10/29 15:15:46, arv wrote:
>
>> LGTM
>>
>
>  I'm not an OWNER so someone else will need to review this too.
>>
>
> Thanks! Technically you are OWNER (core/OWNERS), but I guess you mean
> someone
> from core/loader/OWNERS?
>
> https://codereview.chromium.org/680273004/
>



-- 
erik

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nate Chapin, 2014-10-29 23:03:09]

lgtm

[Jens Widell, 2014-10-30 07:50:39]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-10-30 07:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680273004/1

[commit-bot: I haz the power, 2014-10-30 09:06:53]

Committed patchset #1 (id:1) as 184628