LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html - Issue 680273004: Never fire popstate event when navigating between documents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

Issue 680273004: Never fire popstate event when navigating between documents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/loader/stateobjects/replacestate-in-iframe-expected.txt ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

diff --git a/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html b/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

index 970d6c4936080fdbf5d1614303b6ab9e3a469f05..1be76c064faba0e041f8ddfd257ad32e485ed56a 100644

--- a/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

+++ b/LayoutTests/fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html

@@ -1,17 +1,15 @@

-window.onload = function() {

- if (!sessionStorage.beganTest) {

- sessionStorage.beganTest = true;

- top.opener.windowLoaded();

- }

window.onunload = function() {

// No page cache

}

-window.onpopstate = function(e) {

- alert("onpopstate");

- top.opener.notifyDone(window == parent ? "FAIL" : "PASS");

+window.onpageshow = function(e) {

+ alert("onpageshow");

+ if (!sessionStorage.beganTest) {

+ sessionStorage.beganTest = true;

+ top.opener.windowLoaded();

+ } else {

+ top.opener.notifyDone(window == parent ? "FAIL" : "PASS");

+ }

}

</script>

« no previous file with comments | « LayoutTests/fast/loader/stateobjects/replacestate-in-iframe-expected.txt ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »