Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 680263005: Remove layerIsContainerForFixedPositionLayers. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove layerIsContainerForFixedPositionLayers. We don't have fixed position. We'll later need to remove this functionality from cc as well. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f39a13fcc33bab1908f0e9fbe6d302aafb0a7bb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M sky/engine/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/cc/web_layer_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-28 20:12:45 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-28 20:16:12 UTC) #3
ojan
6 years, 1 month ago (2014-10-28 21:00:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f39a13fcc33bab1908f0e9fbe6d302aafb0a7bb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698