Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 680263005: Remove layerIsContainerForFixedPositionLayers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
index 9c7af6701cc3f65ddd6eb6ec04f8568672bbbb57..6f369d6367e5d5f457bcd9c713a128774f41ebc6 100644
--- a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -652,7 +652,6 @@ void CompositedLayerMapping::updateGraphicsLayerGeometry(const RenderLayer* comp
updateShouldFlattenTransform();
updateChildrenTransform();
updateScrollParent(compositor()->preferCompositingToLCDTextEnabled() ? m_owningLayer.scrollParent() : 0);
- registerScrollingLayers();
updateCompositingReasons();
}
@@ -919,23 +918,6 @@ void CompositedLayerMapping::updateBackgroundLayerGeometry(const FloatSize& rela
m_backgroundLayer->setOffsetFromRenderer(m_graphicsLayer->offsetFromRenderer());
}
-void CompositedLayerMapping::registerScrollingLayers()
-{
- // FIXME(sky): Remove this whole function. I think this doesn't do anything now that we don't support position:fixed.
-
- // Register fixed position layers and their containers with the scrolling coordinator.
- ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m_owningLayer);
- if (!scrollingCoordinator)
- return;
-
- // Page scale is applied as a transform on the root render view layer. Because the scroll
- // layer is further up in the hierarchy, we need to avoid marking the root render view
- // layer as a container.
- bool isContainer = m_owningLayer.hasTransform() && !m_owningLayer.isRootLayer();
- // FIXME: we should make certain that childForSuperLayers will never be the m_squashingContainmentLayer here
- scrollingCoordinator->setLayerIsContainerForFixedPositionLayers(childForSuperlayers(), isContainer);
-}
-
void CompositedLayerMapping::updateInternalHierarchy()
{
// m_foregroundLayer has to be inserted in the correct order with child layers,

Powered by Google App Engine
This is Rietveld 408576698