scripts/slave/recipes/chromium_trybot.py - Issue 680253003: Use remove_build_metadata.py on all the trybots (take 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 680253003: Use remove_build_metadata.py on all the trybots (take 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 65372f1b929c842de0d483bc580252e17cf82de6..9a1f268d5afae37449558429f3aa16806b593163 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -833,9 +833,13 @@ def GenSteps(api):

raise

- # Collect *.isolated hashes for all isolated targets, used when triggering

- # tests on swarming.

if bot_config.get('use_isolate') or has_swarming_tests:

+ # Remove the build metadata from the binaries. Currently it's a noop on

+ # all platforms except Windows where it run zap_timestamp.exe on all the

+ # PE images.

+ api.isolate.remove_build_metadata()

+ # Collect *.isolated hashes for all isolated targets, used when triggering

+ # tests on swarming.

api.isolate.find_isolated_tests(api.chromium.output_dir)

if bot_config['compile_only']: