Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 680253003: Use remove_build_metadata.py on all the trybots (take 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'chromium', 7 'chromium',
8 'chromium_tests', 8 'chromium_tests',
9 'gclient', 9 'gclient',
10 'isolate', 10 'isolate',
(...skipping 815 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 826
827 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra 827 # TODO(phajdan.jr): Set failed tryjob result after recognizing infra
828 # compile failures. We've seen cases of compile with patch failing 828 # compile failures. We've seen cases of compile with patch failing
829 # with build steps getting killed, compile without patch succeeding, 829 # with build steps getting killed, compile without patch succeeding,
830 # and compile with patch succeeding on another attempt with same patch. 830 # and compile with patch succeeding on another attempt with same patch.
831 except api.step.StepFailure: 831 except api.step.StepFailure:
832 api.tryserver.set_transient_failure_tryjob_result() 832 api.tryserver.set_transient_failure_tryjob_result()
833 raise 833 raise
834 raise 834 raise
835 835
836 # Collect *.isolated hashes for all isolated targets, used when triggering
837 # tests on swarming.
838 if bot_config.get('use_isolate') or has_swarming_tests: 836 if bot_config.get('use_isolate') or has_swarming_tests:
837 # Remove the build metadata from the binaries. Currently it's a noop on
838 # all platforms except Windows where it run zap_timestamp.exe on all the
839 # PE images.
840 api.isolate.remove_build_metadata()
841 # Collect *.isolated hashes for all isolated targets, used when triggering
842 # tests on swarming.
839 api.isolate.find_isolated_tests(api.chromium.output_dir) 843 api.isolate.find_isolated_tests(api.chromium.output_dir)
840 844
841 if bot_config['compile_only']: 845 if bot_config['compile_only']:
842 tests = [] 846 tests = []
843 847
844 return tests, bot_update_step 848 return tests, bot_update_step
845 849
846 mastername = api.properties.get('mastername') 850 mastername = api.properties.get('mastername')
847 buildername = api.properties.get('buildername') 851 buildername = api.properties.get('buildername')
848 bot_config = get_bot_config(mastername, buildername) 852 bot_config = get_bot_config(mastername, buildername)
(...skipping 658 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 'test': 'base_tests', 1511 'test': 'base_tests',
1508 'args': ['--gtest-filter: *NaCl*.*'], 1512 'args': ['--gtest-filter: *NaCl*.*'],
1509 }, 1513 },
1510 ], 1514 ],
1511 }) 1515 })
1512 ) + 1516 ) +
1513 api.override_step_data( 1517 api.override_step_data(
1514 'analyze', 1518 'analyze',
1515 api.json.output({'invalid_targets': 'invalid target'})) 1519 api.json.output({'invalid_targets': 'invalid target'}))
1516 ) 1520 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698