power_manager : Allow nocrit use flag to disable low batt shutdown.

power_manager : Allow nocrit use flag to disable low batt shutdown.

Change-Id: Iefecc383f66ff99799c37be22f7185efa5f2e604
Signed-off-by: Benson Leung <bleung@chromium.org>;
Signed-off-by: Sameer Nanda <snanda@chromium.org>;
Signed-off-by: Jonathan Kliegman <kliegs@chromium.org>;

BUG=chrome-os-partner:3127
TEST=built with board with use flag enabled. Ensured that
low_battery_suspend_percent is changed to 0.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3393fd0

[kliegs, 2011-04-05 13:34:49]

Should this do an existence check on the file in case it ever gets moved to
another package?  Similar to how the lid config is setup?

Also will this fix the case where a device constantly reboots if at low
power even if plugged in?   Or is/was there another fix for that?

On Tue, Apr 5, 2011 at 4:27 AM, <bleung@chromium.org> wrote:

> Reviewers: Dave Parker, Sameer Nanda, Olof Johansson,
>
> Description:
> power_manager : Allow nocrit use flag to disable low batt shutdown.
>
> Change-Id: Iefecc383f66ff99799c37be22f7185efa5f2e604
> Signed-off-by: Benson Leung <bleung@chromium.org>
>
> BUG=chrome-os-partner:3127
> TEST=pending
>
>
> Please review this at http://codereview.chromium.org/6797001/
>
> SVN Base: ssh://gitrw.chromium.org:9222/chromiumos-overlay.git@master
>
> Affected files:
>  M chromeos-base/power_manager/power_manager-9999.ebuild
>
>
> Index: chromeos-base/power_manager/power_manager-9999.ebuild
> diff --git a/chromeos-base/power_manager/power_manager-9999.ebuild
> b/chromeos-base/power_manager/power_manager-9999.ebuild
> index
>
165fafc64116b2b185d5d1239eb1fefdf202104f..18aaa16f7a4ae4dc080b5527cee351b7ecbfabc2
> 100644
> --- a/chromeos-base/power_manager/power_manager-9999.ebuild
> +++ b/chromeos-base/power_manager/power_manager-9999.ebuild
> @@ -9,7 +9,7 @@ DESCRIPTION="Power Manager for Chromium OS"
>  HOMEPAGE="http://src.chromium.org"
>  LICENSE="BSD"
>  SLOT="0"
> -IUSE="-new_power_button test -lockvt -touchui"
> +IUSE="-new_power_button test -lockvt -touchui -nocrit"
>  KEYWORDS="~amd64 ~arm ~x86"
>
>  RDEPEND="chromeos-base/libcros
> @@ -122,6 +122,11 @@ src_install() {
>        insinto "/etc/udev/rules.d"
>        doins "${S}/99-light-sensor.rules"
>
> +       if use nocrit; then
> +               echo "0" > \
> +
> "${D}/usr/share/power_manager/low_battery_suspend_percent"
> +       fi
> +
>        if use touchui; then
>                if [ ! -e "${D}/usr/share/power_manager/use_lid" ]; then
>                        die "use_lid config file missing"
>
>
>

[Sameer Nanda, 2011-04-05 15:48:29]

LGTM

http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
File chromeos-base/power_manager/power_manager-9999.ebuild (right):

http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
chromeos-base/power_manager/power_manager-9999.ebuild:125: if use nocrit; then
can you add a comment here as to what nocrit means?

[Benson Leung, 2011-04-05 22:33:30]

http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
File chromeos-base/power_manager/power_manager-9999.ebuild (right):

http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
chromeos-base/power_manager/power_manager-9999.ebuild:125: if use nocrit; then
On 2011/04/05 15:48:29, Sameer Nanda wrote:
> can you add a comment here as to what nocrit means?

Done.

[Sameer Nanda, 2011-04-05 22:36:53]

On 2011/04/05 22:33:30, Benson Leung wrote:
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
> File chromeos-base/power_manager/power_manager-9999.ebuild (right):
> 
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
> chromeos-base/power_manager/power_manager-9999.ebuild:125: if use nocrit; then
> On 2011/04/05 15:48:29, Sameer Nanda wrote:
> > can you add a comment here as to what nocrit means?
> 
> Done.
LGTM

[kliegs, 2011-04-05 22:38:04]

Is nocrit used elsewhere?  What does that USE flag signify or what else does it
enable/disable?

On 2011/04/05 22:33:30, Benson Leung wrote:
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
> File chromeos-base/power_manager/power_manager-9999.ebuild (right):
> 
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
> chromeos-base/power_manager/power_manager-9999.ebuild:125: if use nocrit; then
> On 2011/04/05 15:48:29, Sameer Nanda wrote:
> > can you add a comment here as to what nocrit means?
> 
> Done.

[kliegs, 2011-04-05 22:42:17]

Sorry - and the change LGTM as well.  Don't hold this up on me as long as
you've got LGTM's from the reviewers you asked to review.

On Tue, Apr 5, 2011 at 6:38 PM, <kliegs@chromium.org> wrote:

> Is nocrit used elsewhere?  What does that USE flag signify or what else
> does it
> enable/disable?
>
>
> On 2011/04/05 22:33:30, Benson Leung wrote:
>
>
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
>
>> File chromeos-base/power_manager/power_manager-9999.ebuild (right):
>>
>
>
>
>
http://codereview.chromium.org/6797001/diff/1/chromeos-base/power_manager/pow...
>
>> chromeos-base/power_manager/power_manager-9999.ebuild:125: if use nocrit;
>> then
>> On 2011/04/05 15:48:29, Sameer Nanda wrote:
>> > can you add a comment here as to what nocrit means?
>>
>
>  Done.
>>
>
>
>
> http://codereview.chromium.org/6797001/
>

[Benson Leung, 2011-04-05 22:49:42]

Nocrit is not used anywhere else. It's a specific power manager use flag to
allow us to quickly disable the critical battery behavior on a broken prototype
platform.