Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 679663002: Removed incorrect StyleInvalidator FIXME. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed incorrect StyleInvalidator FIXME. Cloning the RenderStyle, like the FIXME said, is not enough. It would be true if we only scheduled invalidation sets for classes/ids/... not in the rightmost compound selector, but we schedule invalidation sets for classes on the element it needs to invalidate too. Setting class=a on an element with the style rules below requires us to do a LocalStyleChange on both '.a' and '.b' in order to apply the first rule as well. For setting class=x, that wouldn't be necesarry. .a {} .a .b {} .x .y {} It's possible to optimize that case by adding a flag to the invalidation set to indicate that the feature the invalidation set is for is present in the rightmost compound of some selector. R=chrishtr@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
6 years, 2 months ago (2014-10-24 09:47:32 UTC) #1
esprehn
lgtm, lets not optimize just yet.
6 years, 2 months ago (2014-10-24 21:54:58 UTC) #2
rune
On 2014/10/24 at 21:54:58, esprehn wrote: > lgtm, lets not optimize just yet. agree
6 years, 2 months ago (2014-10-24 22:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679663002/1
6 years, 2 months ago (2014-10-24 22:41:57 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-25 00:32:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184394

Powered by Google App Engine
This is Rietveld 408576698