Source/core/css/invalidation/StyleInvalidator.cpp - Issue 679663002: Removed incorrect StyleInvalidator FIXME.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 679663002: Removed incorrect StyleInvalidator FIXME. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp

index 0aa25d7c76d999ee7a8a52db47fcffce2d895e0c..91d7e60bfa2b2e88e4536e82a7b2c95c52a6d339 100644

--- a/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -129,7 +129,6 @@ ALWAYS_INLINE bool StyleInvalidator::checkInvalidationSetsAgainstElement(Element

if (InvalidationList* invalidationList = m_pendingInvalidationMap.get(&element)) {

for (const auto& invalidationSet : *invalidationList)

recursionData.pushInvalidationSet(*invalidationSet);

- // FIXME: It's really only necessary to clone the render style for this element, not full style recalc.

if (UNLIKELY(*s_tracingEnabled)) {

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"),

"StyleInvalidatorInvalidationTracking",

« no previous file with comments | « no previous file | no next file » | no next file with comments »