Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5515)

Unified Diff: chrome/common/extensions/api/file_system_provider.idl

Issue 679573002: [fsp] Separate recursive and non-recursive watchers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/file_system_provider.idl
diff --git a/chrome/common/extensions/api/file_system_provider.idl b/chrome/common/extensions/api/file_system_provider.idl
index d0de7658e8d9f297c3f49d2477d59b22817b7d40..4a07cdc606b4c37e10bb8afdb346d22dde2ad80e 100644
--- a/chrome/common/extensions/api/file_system_provider.idl
+++ b/chrome/common/extensions/api/file_system_provider.idl
@@ -344,8 +344,8 @@ namespace fileSystemProvider {
};
// Information about a change happened to an entry within the observed
- // directory.
- dictionary ChildChange {
+ // directory (including the entry itself).
+ dictionary Change {
// The path of the changed entry.
DOMString entryPath;
@@ -361,13 +361,17 @@ namespace fileSystemProvider {
// The path of the observed entry.
DOMString observedPath;
hirono 2014/10/24 04:34:54 Now we cannot identify an observer by using observ
mtomasz 2014/10/24 05:37:50 Right. I'd like to do it separately, after committ
+ // Mode of the observed entry.
+ boolean recursive;
+
// The type of the change which happened to the observed entry. If it is
// DELETED, then the observed entry will be automatically removed from the
// list of observed entries.
ChangeType changeType;
- // List of changes to entries within the observed directory.
- ChildChange[]? childChanges;
+ // List of changes to entries within the observed directory (including the
+ // entry itself)
+ Change[]? changes;
// Tag for the notification. Required if the file system was mounted with
// the <code>supportsNotifyTag</code> option. Note, that this flag is
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698