[fsp] Separate recursive and non-recursive watchers.

chrome/common/extensions/api/file_system_provider.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.fileSystemProvider</code> API to create file systems,
 // that can be accessible from the file manager on Chrome OS.
 [platforms=("chromeos"),
  implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"]
 namespace fileSystemProvider {
   // Error codes used by providing extensions in response to requests. For
@@ skipping 322 matching lines @@
 
   // Options for the <code>onUnobserveEntryRequested()</code> event.
   dictionary UnobserveEntryRequestedOptions {
     // The identifier of the file system related to this operation.
     DOMString fileSystemId;
 
     // The unique identifier of this request.
     long requestId;
 
     // The path of the entry to be not observed anymore.
     DOMString entryPath;

[hirono, 2014/10/24 04:34:54]

recursive is needed?

[mtomasz, 2014/10/24 05:37:50]

Good catch. Added. Unfortunately we don't have browser tests yet for that, but
they will come very soon.

   };
 
   // Information about a change happened to an entry within the observed
-  // directory.
-  dictionary ChildChange {
+  // directory (including the entry itself).
+  dictionary Change {
     // The path of the changed entry.
     DOMString entryPath;
 
     // The type of the change which happened to the entry.
     ChangeType changeType;
   };
 
   // Options for the <code>Notify()</code> method.
   dictionary NotifyOptions {
     // The identifier of the file system related to this change.
     DOMString fileSystemId;
 
     // The path of the observed entry.
     DOMString observedPath;

[hirono, 2014/10/24 04:34:54]

Now we cannot identify an observer by using observedPath.
How about introducing ID for observer?

[mtomasz, 2014/10/24 05:37:50]

Right. I'd like to do it separately, after committing this one, and 642023003,
though.

 
+    // Mode of the observed entry.
+    boolean recursive;
+
     // The type of the change which happened to the observed entry. If it is
     // DELETED, then the observed entry will be automatically removed from the
     // list of observed entries.
     ChangeType changeType;
 
-    // List of changes to entries within the observed directory.
-    ChildChange[]? childChanges;
+    // List of changes to entries within the observed directory (including the
+    // entry itself)
+    Change[]? changes;
 
     // Tag for the notification. Required if the file system was mounted with
     // the <code>supportsNotifyTag</code> option. Note, that this flag is
     // necessary to provide notifications about changes which changed even
     // when the system was shutdown.
     DOMString? tag;
   };
 
   // Callback to receive the result of mount() function.
   callback MountCallback = void([nodoc, instanceOf=DOMError] object error);
@@ skipping 206 matching lines @@
 
     // Raised when the entry should no longer be observed. If an error occurs,
     // then <code>errorCallback</code> must be called.
     [maxListeners=1, nodoc] static void onUnobserveEntryRequested(
       UnobserveEntryRequestedOptions options,
       ProviderSuccessCallback successCallback,
       ProviderErrorCallback errorCallback);
   };
 };