Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 679443002: minidump: Use forward declarations in more places (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Use forward declarations in more places. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/38aeadc1c1db0e1b3a45df1d9784f57a6032fbbc

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M minidump/minidump_context_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_context_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_crashpad_info_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_crashpad_info_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_exception_writer.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M minidump/minidump_exception_writer.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_file_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_memory_writer.h View 1 2 chunks +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_misc_info_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_misc_info_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_module_writer.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M minidump/minidump_module_writer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_simple_string_dictionary_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_stream_writer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M minidump/minidump_string_writer.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M minidump/minidump_string_writer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_system_info_writer.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M minidump/minidump_system_info_writer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_thread_writer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M minidump/minidump_thread_writer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M minidump/minidump_writable.h View 1 chunk +3 lines, -3 lines 0 comments Download
M minidump/minidump_writable.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-10-23 21:10:45 UTC) #2
Robert Sesek
lgtm
6 years, 1 month ago (2014-10-23 22:44:14 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-10-23 22:47:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
38aeadc1c1db0e1b3a45df1d9784f57a6032fbbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698