Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: minidump/minidump_string_writer.cc

Issue 679443002: minidump: Use forward declarations in more places (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Update Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | minidump/minidump_string_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_string_writer.h" 15 #include "minidump/minidump_string_writer.h"
16 16
17 #include <sys/types.h>
18
17 #include "base/logging.h" 19 #include "base/logging.h"
18 #include "minidump/minidump_writer_util.h" 20 #include "minidump/minidump_writer_util.h"
21 #include "util/file/file_writer.h"
19 #include "util/numeric/safe_assignment.h" 22 #include "util/numeric/safe_assignment.h"
20 23
21 namespace crashpad { 24 namespace crashpad {
22 namespace internal { 25 namespace internal {
23 26
24 template <typename Traits> 27 template <typename Traits>
25 MinidumpStringWriter<Traits>::MinidumpStringWriter() 28 MinidumpStringWriter<Traits>::MinidumpStringWriter()
26 : MinidumpWritable(), string_base_(), string_() { 29 : MinidumpWritable(), string_base_(), string_() {
27 } 30 }
28 31
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 template class MinidumpStringWriter<MinidumpStringWriterUTF8Traits>; 84 template class MinidumpStringWriter<MinidumpStringWriterUTF8Traits>;
82 85
83 void MinidumpUTF16StringWriter::SetUTF8(const std::string& string_utf8) { 86 void MinidumpUTF16StringWriter::SetUTF8(const std::string& string_utf8) {
84 DCHECK_EQ(state(), kStateMutable); 87 DCHECK_EQ(state(), kStateMutable);
85 88
86 set_string(MinidumpWriterUtil::ConvertUTF8ToUTF16(string_utf8)); 89 set_string(MinidumpWriterUtil::ConvertUTF8ToUTF16(string_utf8));
87 } 90 }
88 91
89 } // namespace internal 92 } // namespace internal
90 } // namespace crashpad 93 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | minidump/minidump_string_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698