Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 679403002: Store network_service cache in memory (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Store network_service cache in memory The network cache is not safe for usage by multiple processes at the same time like when sky tests are running many mojo_shell instances in parallel. To work around this we store the cache in memory. In the future we should consider file system partitioning for mojo services. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d2c4163b85c39217c191c48f4732723681209f4a

Patch Set 1 #

Patch Set 2 : Use IN_MEMORY. #

Patch Set 3 : Add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M mojo/services/network/network_context.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
esprehn
6 years, 1 month ago (2014-10-28 18:18:07 UTC) #2
DaveMoore
lgtm
6 years, 1 month ago (2014-10-28 18:27:13 UTC) #3
esprehn
Committed patchset #3 (id:40001) manually as d2c4163b85c39217c191c48f4732723681209f4a (presubmit successful).
6 years, 1 month ago (2014-10-28 18:29:12 UTC) #4
jamesr
FYI this patch is going to be a no-op soon since we're going to consume ...
6 years, 1 month ago (2014-11-01 00:07:59 UTC) #6
abarth-chromium
6 years, 1 month ago (2014-11-03 03:30:11 UTC) #8
Message was sent while issue was closed.
Ported to Chromium repo in https://codereview.chromium.org/697883003

Powered by Google App Engine
This is Rietveld 408576698