Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 697883003: Store network_service cache in memory (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
DaveMoore
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Store network_service cache in memory The network cache is not safe for usage by multiple processes at the same time like when sky tests are running many mojo_shell instances in parallel. To work around this we store the cache in memory. In the future we should consider file system partitioning for mojo services. This CL originally reviewed and landed in the Mojo repo in https://codereview.chromium.org/679403002/. Re-landing in the Chromium repo because this code is canonically developed here. TBR=davemoore@chromium.org Committed: https://crrev.com/07969efff543ef1dffff2ba6a16dd017252eb689 Cr-Commit-Position: refs/heads/master@{#302411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M mojo/services/network/network_context.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-03 03:29:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697883003/1
6 years, 1 month ago (2014-11-03 03:30:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 04:09:55 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 04:10:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07969efff543ef1dffff2ba6a16dd017252eb689
Cr-Commit-Position: refs/heads/master@{#302411}

Powered by Google App Engine
This is Rietveld 408576698