Issue 679363002: Revert of Patch to remove constant attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679363002: Revert of Patch to remove constant attributes (Closed)

Created:
6 years, 1 month ago by joshualitt

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, egdaniel, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Patch to remove constant attributes (patchset #6 id:100001 of https://codereview.chromium.org/678073005/) Reason for revert: Breaks the K1 Original issue's description: > Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2 TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9f2825f249110153eba6c5a5713713033696be5c

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -61 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	include/gpu/gl/GrGLConfig.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLConfig_chrome.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/effects/GrYUVtoRGBEffect.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View	3 chunks	+25 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	2 chunks	+76 lines, -44 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679363002/1

6 years, 1 month ago (2014-10-28 00:55:52 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 00:56:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 9f2825f249110153eba6c5a5713713033696be5c