Source/core/html/forms/NumberInputType.cpp - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/NumberInputType.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added isReset as a parameter to not allow setValue change value of m_textAsOfLastFormControlChangeE… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/NumberInputType.cpp

diff --git a/Source/core/html/forms/NumberInputType.cpp b/Source/core/html/forms/NumberInputType.cpp

index d728ca1652a65181947535c2a711e9b03360f88f..52411e1f3f09c9f20c8590005af9050d6c68a462 100644

--- a/Source/core/html/forms/NumberInputType.cpp

+++ b/Source/core/html/forms/NumberInputType.cpp

@@ -108,11 +108,11 @@ const AtomicString& NumberInputType::formControlType() const

return InputTypeNames::number;

}

-void NumberInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)

+void NumberInputType::setValue(const String& sanitizedValue, bool valueChanged, bool isReset, TextFieldEventBehavior eventBehavior)

{

if (!valueChanged && sanitizedValue.isEmpty() && !element().innerEditorValue().isEmpty())

element().updateView();

- TextFieldInputType::setValue(sanitizedValue, valueChanged, eventBehavior);

+ TextFieldInputType::setValue(sanitizedValue, valueChanged, isReset, eventBehavior);

}

double NumberInputType::valueAsDouble() const