Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added isReset as a parameter to not allow setValue change value of m_textAsOfLastFormControlChangeE… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLInputElement.cpp ('K') | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h ('k') | Source/core/html/forms/ColorInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index 13b634510254d48a4b7956e3e8d1a269ae775689..751706c42b9b7bb081ecc4ec90315ab1fedbd97c 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -487,9 +487,9 @@ FormControlState BaseMultipleFieldsDateAndTimeInputType::saveFormControlState()

return FormControlState();

}

-void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedValue, bool valueChanged, TextFieldEventBehavior eventBehavior)

+void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedValue, bool valueChanged, bool isReset, TextFieldEventBehavior eventBehavior)

{

- InputType::setValue(sanitizedValue, valueChanged, eventBehavior);

+ InputType::setValue(sanitizedValue, valueChanged, isReset, eventBehavior);

DateTimeEditElement* edit = dateTimeEditElement();

if (valueChanged || (sanitizedValue.isEmpty() && edit && edit->anyEditableFieldsHaveValues())) {

element().updateView();