Source/core/html/forms/BaseCheckableInputType.cpp - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseCheckableInputType.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added isReset as a parameter to not allow setValue change value of m_textAsOfLastFormControlChangeE… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/BaseCheckableInputType.cpp

diff --git a/Source/core/html/forms/BaseCheckableInputType.cpp b/Source/core/html/forms/BaseCheckableInputType.cpp

index 30156400440150b0968098c8325796af8f4453df..1d611907eeef1f32ce503490545713381acd0311 100644

--- a/Source/core/html/forms/BaseCheckableInputType.cpp

+++ b/Source/core/html/forms/BaseCheckableInputType.cpp

@@ -101,7 +101,7 @@ bool BaseCheckableInputType::storesValueSeparateFromAttribute()

return false;

}

-void BaseCheckableInputType::setValue(const String& sanitizedValue, bool, TextFieldEventBehavior)

+void BaseCheckableInputType::setValue(const String& sanitizedValue, bool, bool, TextFieldEventBehavior)

{

element().setAttribute(valueAttr, AtomicString(sanitizedValue));

}