Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67923002: Fixes for -Wunused-function on Linux, Android and ChromeOS (Closed)

Created:
7 years, 1 month ago by hans
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, vandebo (ex-Chrome), cbentzel+watch_chromium.org, erikwright+watch_chromium.org, Lei Zhang, tommycli, Greg Billock, James Su, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Fixes for -Wunused-function on Linux, Android and ChromeOS BUG=315884, 78045 TBR=owners Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234373

Patch Set 1 #

Patch Set 2 : Pick up blink r161688 #

Patch Set 3 : Rebase #

Patch Set 4 : Android fix #

Patch Set 5 : ChromeOS fix #

Patch Set 6 : android #

Patch Set 7 : chromeos #

Patch Set 8 : aura fix #

Patch Set 9 : chromeos fix #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Total comments: 32

Patch Set 15 : Address thakis's comments #

Patch Set 16 : Rebase #

Patch Set 17 : Rebase for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -546 lines) Patch
M android_webview/browser/in_process_view_renderer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -8 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -13 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -26 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -15 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -5 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -8 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 2 chunks +2 lines, -55 lines 0 comments Download
M base/process/memory_linux.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M base/security_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_traffic_detector.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/chrome_signin_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_frame_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/ime/ibus_daemon_controller.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -35 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_virtual_contexts_unittests.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -0 lines 0 comments Download
M net/ssl/server_bound_cert_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +15 lines, -12 lines 0 comments Download
M net/test/python_utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/tools/balsa/balsa_frame.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +0 lines, -40 lines 0 comments Download
M ui/gfx/interpolated_transform_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/snapshot/test/run_all_unittests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +3 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hans
7 years, 1 month ago (2013-11-10 04:25:27 UTC) #1
Nico
Nice, thanks! A few minor comments, but basically lgtm. https://codereview.chromium.org/67923002/diff/540001/base/files/file_path_watcher_browsertest.cc File base/files/file_path_watcher_browsertest.cc (left): https://codereview.chromium.org/67923002/diff/540001/base/files/file_path_watcher_browsertest.cc#oldcode852 base/files/file_path_watcher_browsertest.cc:852: ...
7 years, 1 month ago (2013-11-10 05:07:09 UTC) #2
hans
Thanks for the review! https://codereview.chromium.org/67923002/diff/540001/base/files/file_path_watcher_browsertest.cc File base/files/file_path_watcher_browsertest.cc (left): https://codereview.chromium.org/67923002/diff/540001/base/files/file_path_watcher_browsertest.cc#oldcode852 base/files/file_path_watcher_browsertest.cc:852: #endif On 2013/11/10 05:07:09, Nico ...
7 years, 1 month ago (2013-11-11 19:29:50 UTC) #3
Nico
lgtm! I think you can land this with "TBR=owners", since these are mostly mechanical changes.
7 years, 1 month ago (2013-11-11 19:39:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/67923002/730001
7 years, 1 month ago (2013-11-11 19:53:52 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-11 20:45:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/67923002/730001
7 years, 1 month ago (2013-11-11 20:50:52 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 01:59:11 UTC) #8
Message was sent while issue was closed. 
Change committed as 234373

Powered by Google App Engine
This is Rietveld 408576698