Issue 679213002: Minor cleanup of view manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679213002: Minor cleanup of view manager (Closed)

Created:
6 years, 1 month ago by sky

Modified:
6 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Minor cleanup of view manager . ViewManagerServiceImpl would previously delete itself or ConnectionManager would delete it. Now ConnectionManager always deletes it. . ViewManagerApp now terminates if either the nativew viewport is destroyed or connection to windowmanager errors out. BUG=none TEST=none R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0aa4fd22985618a6106f3d966b764381d5d8a9cd

Patch Set 1 #

Patch Set 2 : blah #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -95 lines)			Patch
M	mojo/services/view_manager/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/view_manager/connection_manager.h	View		5 chunks	+15 lines, -13 lines	0 comments	Download
M	mojo/services/view_manager/connection_manager.cc	View	1	10 chunks	+75 lines, -54 lines	0 comments	Download
A	mojo/services/view_manager/connection_manager_delegate.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	mojo/services/view_manager/main.cc	View		1 chunk	+12 lines, -8 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.h	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.cc	View		6 chunks	+15 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 1 month ago (2014-10-27 20:25:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0aa4fd22985618a6106f3d966b764381d5d8a9cd (presubmit successful).

Expand Messages | Collapse Messages