Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.h

Issue 679213002: Minor cleanup of view manager (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: blah Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/view_manager/main.cc ('k') | mojo/services/view_manager/view_manager_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/view_manager_service_impl.h
diff --git a/mojo/services/view_manager/view_manager_service_impl.h b/mojo/services/view_manager/view_manager_service_impl.h
index ef9fc5722ab0c9f1193ea54c99a2830f21bcb771..455bd0ba0e5b58134bf5b64c22bb8fd015309886 100644
--- a/mojo/services/view_manager/view_manager_service_impl.h
+++ b/mojo/services/view_manager/view_manager_service_impl.h
@@ -49,10 +49,6 @@ class MOJO_VIEW_MANAGER_EXPORT ViewManagerServiceImpl
InterfaceRequest<ServiceProvider> service_provider);
~ViewManagerServiceImpl() override;
- // Used to mark this connection as originating from a call to
- // ViewManagerService::Connect(). When set OnConnectionError() deletes |this|.
- void set_delete_on_connection_error() { delete_on_connection_error_ = true; }
-
ConnectionSpecificId id() const { return id_; }
ConnectionSpecificId creator_id() const { return creator_id_; }
const std::string& url() const { return url_; }
@@ -152,6 +148,9 @@ class MOJO_VIEW_MANAGER_EXPORT ViewManagerServiceImpl
// |view| is the view that is changing to the drawn state |new_drawn_value|.
void NotifyDrawnStateChanged(const ServerView* view, bool new_drawn_value);
+ // Deletes all Views we own.
+ void DestroyViews();
+
// ViewManagerService:
void CreateView(Id transport_view_id,
const Callback<void(ErrorCode)>& callback) override;
@@ -227,9 +226,6 @@ class MOJO_VIEW_MANAGER_EXPORT ViewManagerServiceImpl
// connections.
ViewIdSet roots_;
- // See description above setter.
- bool delete_on_connection_error_;
-
InterfaceRequest<ServiceProvider> service_provider_;
DISALLOW_COPY_AND_ASSIGN(ViewManagerServiceImpl);
« no previous file with comments | « mojo/services/view_manager/main.cc ('k') | mojo/services/view_manager/view_manager_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698