Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1995)

Unified Diff: tests/lib/convert/json_utf8_chunk_test.dart

Issue 679143003: Fix test warnings and expect Safari mobile simulator bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/corelib/corelib.status ('K') | « tests/lib/convert/json_chunk_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/convert/json_utf8_chunk_test.dart
diff --git a/tests/lib/convert/json_utf8_chunk_test.dart b/tests/lib/convert/json_utf8_chunk_test.dart
index 27324ed2ba14c399873e829acdec8e05543b7b49..efa8593df5cadcc3f129917846790b113fee2117 100644
--- a/tests/lib/convert/json_utf8_chunk_test.dart
+++ b/tests/lib/convert/json_utf8_chunk_test.dart
@@ -204,7 +204,7 @@ void jsonMalformedTest(name, expect, codes) {
}
{ // Not allowing malformed, expect throw.
var sink = new ChunkedConversionSink.withCallback((values) {
- Expect.unreachable(tag);
+ Expect.fail(tag);
});
var decoderSink = JSON.decoder.startChunkedConversion(sink)
.asUtf8Sink(false);
@@ -240,7 +240,7 @@ void jsonThrows(String name, String codeString) {
testJsonThrows(tag, action) {
// Not allowing malformed, expect throw.
var sink = new ChunkedConversionSink.withCallback((values) {
- Expect.unreachable(tag);
+ Expect.fail(tag);
});
var decoderSink = JSON.decoder.startChunkedConversion(sink)
.asUtf8Sink(true);
« tests/corelib/corelib.status ('K') | « tests/lib/convert/json_chunk_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698