Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/lib/convert/json_chunk_test.dart

Issue 679143003: Fix test warnings and expect Safari mobile simulator bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/corelib/corelib.status ('K') | « tests/corelib/corelib.status ('k') | tests/lib/convert/json_utf8_chunk_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/convert/json_chunk_test.dart
diff --git a/tests/lib/convert/json_chunk_test.dart b/tests/lib/convert/json_chunk_test.dart
index 22f3ebad7d6e60dcde8c9582698c088f6aa671d8..28e92977913fe95ec8f44f3b2b1d8214d822a50b 100644
--- a/tests/lib/convert/json_chunk_test.dart
+++ b/tests/lib/convert/json_chunk_test.dart
@@ -20,7 +20,7 @@ jsonTest(testName, expect, action(sink)) {
jsonThrowsTest(testName, action(sink)) {
var sink = new ChunkedConversionSink.withCallback((values) {
- Expect.unreachable("Should have thrown.", testName);
+ Expect.fail("Should have thrown: $testName");
});
var decoderSink = JSON.decoder.startChunkedConversion(sink);
Expect.throws(() { action(decoderSink); }, (e) => e is FormatException,
« tests/corelib/corelib.status ('K') | « tests/corelib/corelib.status ('k') | tests/lib/convert/json_utf8_chunk_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698