Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 679133002: ScreenObserver is renamed to BaseScreenDelegate. (Closed)

Created:
6 years, 1 month ago by ygorshenin1
Modified:
6 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ScreenObserver is renamed to BaseScreenDelegate. BUG=405876 TEST=existing unit_tests and browser_tests. Committed: https://crrev.com/a46dd17dd81d8cad501f8a3ee2fbeaa000641404 Cr-Commit-Position: refs/heads/master@{#301619}

Patch Set 1 #

Patch Set 2 : ScreenDelegate -> BaseScreenDelegate. #

Patch Set 3 : Fixes. #

Total comments: 4

Patch Set 4 : Fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -427 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 5 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.h View 1 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/login/screens/base_screen_delegate.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen_unittest.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/login/screens/mock_base_screen_delegate.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/screens/mock_base_screen_delegate.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_error_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_error_screen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_eula_screen.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_eula_screen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_network_screen.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_network_screen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/screens/mock_screen_observer.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/chromeos/login/screens/mock_screen_observer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/login/screens/screen_observer.h View 1 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 7 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 15 chunks +37 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 27 chunks +43 lines, -44 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
ygorshenin1
6 years, 1 month ago (2014-10-28 09:29:57 UTC) #2
Nikita (slow)
In case you haven't seen, there're couple of useful tools: tools/git/move_source_file.py tools/git/mffr.py
6 years, 1 month ago (2014-10-28 09:41:08 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_browser_chromeos.gypi#newcode532 chrome/chrome_browser_chromeos.gypi:532: 'browser/chromeos/login/screens/base_screen_delegate.h', nit: sort https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_tests.gypi#newcode166 ...
6 years, 1 month ago (2014-10-28 09:46:50 UTC) #4
ygorshenin1
Thanks! https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/679133002/diff/40001/chrome/chrome_browser_chromeos.gypi#newcode532 chrome/chrome_browser_chromeos.gypi:532: 'browser/chromeos/login/screens/base_screen_delegate.h', On 2014/10/28 09:46:49, Nikita Kostylev wrote: > ...
6 years, 1 month ago (2014-10-28 10:07:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679133002/60001
6 years, 1 month ago (2014-10-28 10:08:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/73667)
6 years, 1 month ago (2014-10-28 10:38:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679133002/60001
6 years, 1 month ago (2014-10-28 10:41:59 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-28 12:07:37 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 12:08:22 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a46dd17dd81d8cad501f8a3ee2fbeaa000641404
Cr-Commit-Position: refs/heads/master@{#301619}

Powered by Google App Engine
This is Rietveld 408576698