Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/chromeos/login/screens/network_screen_browsertest.cc

Issue 679133002: ScreenObserver is renamed to BaseScreenDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "chrome/browser/chromeos/login/helper.h" 6 #include "chrome/browser/chromeos/login/helper.h"
7 #include "chrome/browser/chromeos/login/screens/base_screen.h" 7 #include "chrome/browser/chromeos/login/screens/base_screen.h"
8 #include "chrome/browser/chromeos/login/screens/mock_screen_observer.h" 8 #include "chrome/browser/chromeos/login/screens/mock_base_screen_delegate.h"
9 #include "chrome/browser/chromeos/login/screens/network_screen.h" 9 #include "chrome/browser/chromeos/login/screens/network_screen.h"
10 #include "chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h" 10 #include "chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h"
11 #include "chrome/browser/chromeos/login/wizard_controller.h" 11 #include "chrome/browser/chromeos/login/wizard_controller.h"
12 #include "chrome/test/base/ui_test_utils.h" 12 #include "chrome/test/base/ui_test_utils.h"
13 #include "chromeos/dbus/dbus_thread_manager.h" 13 #include "chromeos/dbus/dbus_thread_manager.h"
14 #include "chromeos/dbus/fake_session_manager_client.h" 14 #include "chromeos/dbus/fake_session_manager_client.h"
15 #include "content/public/test/test_utils.h" 15 #include "content/public/test/test_utils.h"
16 #include "testing/gmock/include/gmock/gmock.h" 16 #include "testing/gmock/include/gmock/gmock.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 #include "third_party/cros_system_api/dbus/service_constants.h" 18 #include "third_party/cros_system_api/dbus/service_constants.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual void SetUpInProcessBrowserTestFixture() override { 53 virtual void SetUpInProcessBrowserTestFixture() override {
54 WizardInProcessBrowserTest::SetUpInProcessBrowserTestFixture(); 54 WizardInProcessBrowserTest::SetUpInProcessBrowserTestFixture();
55 55
56 fake_session_manager_client_ = new FakeSessionManagerClient; 56 fake_session_manager_client_ = new FakeSessionManagerClient;
57 DBusThreadManager::GetSetterForTesting()->SetSessionManagerClient( 57 DBusThreadManager::GetSetterForTesting()->SetSessionManagerClient(
58 scoped_ptr<SessionManagerClient>(fake_session_manager_client_)); 58 scoped_ptr<SessionManagerClient>(fake_session_manager_client_));
59 } 59 }
60 60
61 virtual void SetUpOnMainThread() override { 61 virtual void SetUpOnMainThread() override {
62 WizardInProcessBrowserTest::SetUpOnMainThread(); 62 WizardInProcessBrowserTest::SetUpOnMainThread();
63 mock_screen_observer_.reset(new MockScreenObserver()); 63 mock_base_screen_delegate_.reset(new MockBaseScreenDelegate());
64 ASSERT_TRUE(WizardController::default_controller() != NULL); 64 ASSERT_TRUE(WizardController::default_controller() != NULL);
65 network_screen_ = 65 network_screen_ =
66 NetworkScreen::Get(WizardController::default_controller()); 66 NetworkScreen::Get(WizardController::default_controller());
67 ASSERT_TRUE(network_screen_ != NULL); 67 ASSERT_TRUE(network_screen_ != NULL);
68 ASSERT_EQ(WizardController::default_controller()->current_screen(), 68 ASSERT_EQ(WizardController::default_controller()->current_screen(),
69 network_screen_); 69 network_screen_);
70 network_screen_->screen_observer_ = mock_screen_observer_.get(); 70 network_screen_->base_screen_delegate_ = mock_base_screen_delegate_.get();
71 ASSERT_TRUE(network_screen_->actor() != NULL); 71 ASSERT_TRUE(network_screen_->actor() != NULL);
72 72
73 mock_network_state_helper_ = new login::MockNetworkStateHelper; 73 mock_network_state_helper_ = new login::MockNetworkStateHelper;
74 SetDefaultNetworkStateHelperExpectations(); 74 SetDefaultNetworkStateHelperExpectations();
75 network_screen_->SetNetworkStateHelperForTest(mock_network_state_helper_); 75 network_screen_->SetNetworkStateHelperForTest(mock_network_state_helper_);
76 } 76 }
77 77
78 virtual void TearDownInProcessBrowserTestFixture() override { 78 virtual void TearDownInProcessBrowserTestFixture() override {
79 InProcessBrowserTest::TearDownInProcessBrowserTestFixture(); 79 InProcessBrowserTest::TearDownInProcessBrowserTestFixture();
80 } 80 }
81 81
82 void EmulateContinueButtonExit(NetworkScreen* network_screen) { 82 void EmulateContinueButtonExit(NetworkScreen* network_screen) {
83 EXPECT_CALL(*mock_screen_observer_, 83 EXPECT_CALL(*mock_base_screen_delegate_,
84 OnExit(ScreenObserver::NETWORK_CONNECTED)) 84 OnExit(BaseScreenDelegate::NETWORK_CONNECTED)).Times(1);
85 .Times(1);
86 EXPECT_CALL(*mock_network_state_helper_, IsConnected()) 85 EXPECT_CALL(*mock_network_state_helper_, IsConnected())
87 .WillOnce(Return(true)); 86 .WillOnce(Return(true));
88 network_screen->OnContinuePressed(); 87 network_screen->OnContinuePressed();
89 content::RunAllPendingInMessageLoop(); 88 content::RunAllPendingInMessageLoop();
90 } 89 }
91 90
92 void SetDefaultNetworkStateHelperExpectations() { 91 void SetDefaultNetworkStateHelperExpectations() {
93 EXPECT_CALL(*mock_network_state_helper_, GetCurrentNetworkName()) 92 EXPECT_CALL(*mock_network_state_helper_, GetCurrentNetworkName())
94 .Times(AnyNumber()) 93 .Times(AnyNumber())
95 .WillRepeatedly((Return(base::string16()))); 94 .WillRepeatedly((Return(base::string16())));
96 EXPECT_CALL(*mock_network_state_helper_, IsConnected()) 95 EXPECT_CALL(*mock_network_state_helper_, IsConnected())
97 .Times(AnyNumber()) 96 .Times(AnyNumber())
98 .WillRepeatedly((Return(false))); 97 .WillRepeatedly((Return(false)));
99 EXPECT_CALL(*mock_network_state_helper_, IsConnecting()) 98 EXPECT_CALL(*mock_network_state_helper_, IsConnecting())
100 .Times(AnyNumber()) 99 .Times(AnyNumber())
101 .WillRepeatedly((Return(false))); 100 .WillRepeatedly((Return(false)));
102 } 101 }
103 102
104 scoped_ptr<MockScreenObserver> mock_screen_observer_; 103 scoped_ptr<MockBaseScreenDelegate> mock_base_screen_delegate_;
105 login::MockNetworkStateHelper* mock_network_state_helper_; 104 login::MockNetworkStateHelper* mock_network_state_helper_;
106 NetworkScreen* network_screen_; 105 NetworkScreen* network_screen_;
107 FakeSessionManagerClient* fake_session_manager_client_; 106 FakeSessionManagerClient* fake_session_manager_client_;
108 107
109 private: 108 private:
110 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest); 109 DISALLOW_COPY_AND_ASSIGN(NetworkScreenTest);
111 }; 110 };
112 111
113 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, CanConnect) { 112 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, CanConnect) {
114 EXPECT_CALL(*mock_network_state_helper_, IsConnecting()) 113 EXPECT_CALL(*mock_network_state_helper_, IsConnecting())
(...skipping 27 matching lines...) Expand all
142 // EXPECT_FALSE(actor_->IsConnecting()); 141 // EXPECT_FALSE(actor_->IsConnecting());
143 network_screen_->OnConnectionTimeout(); 142 network_screen_->OnConnectionTimeout();
144 143
145 // Close infobubble with error message - it makes the test stable. 144 // Close infobubble with error message - it makes the test stable.
146 // EXPECT_FALSE(actor_->IsContinueEnabled()); 145 // EXPECT_FALSE(actor_->IsContinueEnabled());
147 // EXPECT_FALSE(actor_->IsConnecting()); 146 // EXPECT_FALSE(actor_->IsConnecting());
148 // actor_->ClearErrors(); 147 // actor_->ClearErrors();
149 } 148 }
150 149
151 } // namespace chromeos 150 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/screens/network_screen.cc ('k') | chrome/browser/chromeos/login/screens/reset_screen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698