Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 679113005: Hollow out more of the tracing system in oilpan (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Hollow out more of the tracing system in oilpan The goal here was to delete all the oilpan conversion types and then as well all the calls into trace(). In the process of attempting to get it compiling I removed some trace() calls from the font system before finding the one stray trace() call I had missed in handle causing the link errors. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/031be1415710de0872f6e7746e65e800b04a605c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -521 lines) Patch
M sky/engine/bindings/core/v8/Nullable.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromiseProperty.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -33 lines 0 comments Download
M sky/engine/core/css/FontFace.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/FontFace.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.cpp View 3 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 6 chunks +0 lines, -214 lines 0 comments Download
M sky/engine/platform/heap/Heap.h View 15 chunks +4 lines, -123 lines 0 comments Download
M sky/engine/platform/heap/Visitor.h View 11 chunks +0 lines, -63 lines 0 comments Download
M sky/engine/platform/heap/Visitor.cpp View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-10-27 21:39:00 UTC) #1
eseidel
Committed patchset #1 (id:1) manually as 031be1415710de0872f6e7746e65e800b04a605c (presubmit successful).
6 years, 1 month ago (2014-10-27 21:45:55 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-27 21:52:36 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698