Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: sky/engine/bindings/core/v8/ScriptPromiseProperty.h

Issue 679113005: Hollow out more of the tracing system in oilpan (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/Nullable.h ('k') | sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/ScriptPromiseProperty.h
diff --git a/sky/engine/bindings/core/v8/ScriptPromiseProperty.h b/sky/engine/bindings/core/v8/ScriptPromiseProperty.h
index 3997a0ba995a0b505bdc1daa4544ffe15cb70082..6a503bc44152eaf21103fb9ec0332df38fafc8e1 100644
--- a/sky/engine/bindings/core/v8/ScriptPromiseProperty.h
+++ b/sky/engine/bindings/core/v8/ScriptPromiseProperty.h
@@ -68,8 +68,6 @@ public:
// This method keeps the holder object and the property name.
void reset();
- virtual void trace(Visitor*) override;
-
private:
virtual v8::Handle<v8::Object> holder(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
virtual v8::Handle<v8::Value> resolvedValue(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
@@ -145,15 +143,6 @@ void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::reset()
m_rejected = RejectedType();
}
-template<typename HolderType, typename ResolvedType, typename RejectedType>
-void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::trace(Visitor* visitor)
-{
- TraceIfNeeded<HolderType>::trace(visitor, &m_holder);
- TraceIfNeeded<ResolvedType>::trace(visitor, &m_resolved);
- TraceIfNeeded<RejectedType>::trace(visitor, &m_rejected);
- ScriptPromisePropertyBase::trace(visitor);
-}
-
} // namespace blink
#endif // ScriptPromiseProperty_h
« no previous file with comments | « sky/engine/bindings/core/v8/Nullable.h ('k') | sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698