Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 679113004: Use approximate scratch textures for image filters. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update ignored-tests.txt #

Patch Set 3 : -one more time we're gonna celebrate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 2 chunks +48 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
bsalomon
This didn't change any GMs on my desktop machine.
6 years, 1 month ago (2014-10-27 19:20:01 UTC) #2
Stephen White
LGTM. w00t!
6 years, 1 month ago (2014-10-27 19:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679113004/1
6 years, 1 month ago (2014-10-27 19:33:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 96c60686eef6fc514feba6136f1b475f71dbf3ec
6 years, 1 month ago (2014-10-27 19:41:51 UTC) #7
bsalomon
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/664823003/ by bsalomon@google.com. ...
6 years, 1 month ago (2014-10-27 19:58:29 UTC) #8
bsalomon
On 2014/10/27 19:58:29, bsalomon wrote: > A revert of this CL (patchset #1 id:1) has ...
6 years, 1 month ago (2014-10-27 20:47:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679113004/20001
6 years, 1 month ago (2014-10-27 20:47:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 50a140563c5960acb2479d2be7c437d146963b3f
6 years, 1 month ago (2014-10-27 20:56:25 UTC) #12
hcm
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/681183002/ by hcm@google.com. ...
6 years, 1 month ago (2014-10-28 04:42:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679113004/40001
6 years, 1 month ago (2014-10-28 13:54:06 UTC) #15
Stephen White
6 years, 1 month ago (2014-10-28 13:59:43 UTC) #16
On 2014/10/28 13:54:06, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/679113004/40001

I've noticed some problems with this change, unfortunately. Unchecking CQ.

Powered by Google App Engine
This is Rietveld 408576698