Issue 678833002: Revert the if -> DCHECK change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 678833002: Revert the if -> DCHECK change (Closed)

Created:
6 years, 2 months ago by oshima

Modified:
6 years, 2 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src@master

Project:
chromium

Visibility:
Public.

Revert the if -> DCHECK change This is called when window for web contents gets added to the activity window, so this must be if not dcheck. BUG=427003 R=mukai@chromium.org Committed: https://crrev.com/22dc5ff3ebf33f9e9a40e0f71939fd274e13972b Cr-Commit-Position: refs/heads/master@{#301241}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	athena/wm/window_list_provider_impl.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/22dc5ff3ebf33f9e9a40e0f71939fd274e13972b Cr-Commit-Position: refs/heads/master@{#301241}

6 years, 2 months ago (2014-10-25 00:21:13 UTC) #4

oshima

6 years, 2 months ago (2014-10-25 00:21:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
22dc5ff3ebf33f9e9a40e0f71939fd274e13972b (presubmit successful).