athena/wm/window_list_provider_impl.cc - Issue 678833002: Revert the if -> DCHECK change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/wm/window_list_provider_impl.cc

Issue 678833002: Revert the if -> DCHECK change (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/wm/window_list_provider_impl.cc

diff --git a/athena/wm/window_list_provider_impl.cc b/athena/wm/window_list_provider_impl.cc

index 74b0a9bd69b7159166f4b2b5070e5baf7e92831f..cfcb7ebeeca91bf07235dadfb7e6868e057781e4 100644

--- a/athena/wm/window_list_provider_impl.cc

+++ b/athena/wm/window_list_provider_impl.cc

@@ -97,8 +97,7 @@ void WindowListProviderImpl::RecreateWindowList() {

}

void WindowListProviderImpl::OnWindowAdded(aura::Window* window) {

- DCHECK_EQ(window->parent(), container_);

- if (!IsValidWindow(window))

+ if (!IsValidWindow(window) || window->parent() != container_)

return;

window->SetProperty(kManagedKey, true);

« no previous file with comments | « no previous file | no next file » | no next file with comments »