Issue 67883007: [Downloads] Don't store or use validators unless they are strong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67883007: [Downloads] Don't store or use validators unless they are strong. (Closed)

Created:
7 years, 1 month ago by asanka

Modified:
7 years ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Downloads] Don't store or use validators unless they are strong. ETag and Last-Modified headers shouldn't be used unless they imply byte-wise equivalence. While RFC 2616 states that a client 'MAY' use them anyway, we are going to be conservative and only use them if they are strong. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237349

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	content/browser/download/download_resource_handler.cc	View	1	1 chunk	+9 lines, -6 lines	0 comments	Download
	M	net/tools/testserver/testserver.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/67883007/50001

7 years ago (2013-11-25 22:40:00 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=193046

7 years ago (2013-11-25 23:27:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/67883007/50001

7 years ago (2013-11-26 15:31:27 UTC) #5

Message was sent while issue was closed.

Change committed as 237349

Expand Messages | Collapse Messages