Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 678773002: cc: Always use invalidation on the pending tree when deciding to share (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 1 month ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Always use invalidation on the pending tree when deciding to share The invalidation on the active tree shouldn't prevent new tiles on the active tree from sharing with the pending tree. Instead, the invalidation on the pending tree should. The current code can lead to us re-rastering content for no reason on the active tree, when it is already available on the pending tree. Or sharing with the pending tree when it's not appropriate causing a non-atomic frame update during scrolling with pending tree content appearing on the active tree too soon. R=enne, vmpstr BUG=387116 Committed: https://crrev.com/82e46120237bc023559ac7ebddb29e21b6530170 Cr-Commit-Position: refs/heads/master@{#301193} Committed: https://crrev.com/10f4b33a87375fc1becabf30d82a005b8d13158c Cr-Commit-Position: refs/heads/master@{#301391}

Patch Set 1 #

Patch Set 2 : getpendinginvalidation: withoutfortesting #

Patch Set 3 : getpendinginvalidation: comment #

Patch Set 4 : getpendinginvalidation: comment2 #

Patch Set 5 : getpendinginvalidation: rebase #

Patch Set 6 : getpendinginvalidation: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -9 lines) Patch
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 4 1 chunk +7 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 5 1 chunk +60 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
danakj
6 years, 2 months ago (2014-10-24 19:58:34 UTC) #1
danakj
Without new ForTesting method now
6 years, 2 months ago (2014-10-24 20:07:50 UTC) #2
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-24 20:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678773002/60001
6 years, 2 months ago (2014-10-24 20:20:02 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-24 21:30:24 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/82e46120237bc023559ac7ebddb29e21b6530170 Cr-Commit-Position: refs/heads/master@{#301193}
6 years, 2 months ago (2014-10-24 21:31:02 UTC) #7
danakj
This got reverted in order to revert https://codereview.chromium.org/676953003/ So I've rebased this and relanding it.
6 years, 1 month ago (2014-10-27 14:38:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678773002/80001
6 years, 1 month ago (2014-10-27 14:38:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/6519)
6 years, 1 month ago (2014-10-27 15:22:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678773002/100001
6 years, 1 month ago (2014-10-27 16:49:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78933)
6 years, 1 month ago (2014-10-27 17:00:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678773002/100001
6 years, 1 month ago (2014-10-27 17:03:01 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-10-27 17:57:24 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 17:58:12 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/10f4b33a87375fc1becabf30d82a005b8d13158c
Cr-Commit-Position: refs/heads/master@{#301391}

Powered by Google App Engine
This is Rietveld 408576698