cc/resources/picture_layer_tiling.cc - Issue 678773002: cc: Always use invalidation on the pending tree when deciding to share

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/picture_layer_tiling.cc

Issue 678773002: cc: Always use invalidation on the pending tree when deciding to share (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: getpendinginvalidation: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/picture_layer_tiling.cc

diff --git a/cc/resources/picture_layer_tiling.cc b/cc/resources/picture_layer_tiling.cc

index 4dc46e0820b04062bbb8621ed8ef32985a51d4bc..1d8553902c054fe96520f57a3bc0c6361419a552 100644

--- a/cc/resources/picture_layer_tiling.cc

+++ b/cc/resources/picture_layer_tiling.cc

@@ -126,7 +126,8 @@ Tile* PictureLayerTiling::CreateTile(int i,

if (Tile* candidate_tile = twin_tiling->TileAt(i, j)) {

gfx::Rect rect =

gfx::ScaleToEnclosingRect(paint_rect, 1.0f / contents_scale_);

- if (!client_->GetInvalidation()->Intersects(rect)) {

+ const Region* invalidation = client_->GetPendingInvalidation();

+ if (!invalidation || !invalidation->Intersects(rect)) {

DCHECK(!candidate_tile->is_shared());

DCHECK_EQ(i, candidate_tile->tiling_i_index());

DCHECK_EQ(j, candidate_tile->tiling_j_index());

« no previous file with comments | « cc/resources/picture_layer_tiling.h ('k') | cc/test/fake_picture_layer_tiling_client.h » ('j') | no next file with comments »