Issue 678703004: Remove a bunch of dead files found by missing_from_gn

Issue 678703004: Remove a bunch of dead files found by missing_from_gn (Closed)

Created:
6 years, 2 months ago by eseidel

Modified:
6 years, 2 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, brettw, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Visibility:
Public.

Remove a bunch of dead files found by missing_from_gn I also fixed several errors in our BUILD.gn files including bad script dependencies found by missing_from_gn and gn check. Still need to figure out how best to handle :libraries deps being private to :core, etc. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2ff05391561bad2a2e646be8aa46aa80a3fbc783

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -2024 lines)			Patch
D	sky/engine/bindings/core/v8/DebuggerScript.js	View	1 chunk	+0 lines, -548 lines	0 comments	Download
D	sky/engine/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp	View	1 chunk	+0 lines, -82 lines	0 comments	Download
D	sky/engine/build/scripts/check_objc_rename.sh	View	1 chunk	+0 lines, -79 lines	0 comments	Download
M	sky/engine/core/BUILD.gn	View	3 chunks	+13 lines, -14 lines	0 comments	Download
M	sky/engine/core/core.gni	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/css/CSSPropertyMetadata.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	sky/engine/core/inspector/TraceEventDispatcher.h	View	1 chunk	+0 lines, -187 lines	0 comments	Download
D	sky/engine/core/inspector/TraceEventDispatcher.cpp	View	1 chunk	+0 lines, -160 lines	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	4 chunks	+0 lines, -25 lines	0 comments	Download
D	sky/engine/platform/clipboard/ClipboardUtilitiesWin.cpp	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	sky/engine/platform/fonts/opentype/OpenTypeUtilities.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	sky/engine/platform/fonts/opentype/OpenTypeUtilities.cpp	View	1 chunk	+0 lines, -224 lines	0 comments	Download
D	sky/engine/platform/text/LocaleWin.cpp	View	1 chunk	+0 lines, -584 lines	0 comments	Download
M	sky/tools/missing_from_gn	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

eseidel

6 years, 2 months ago (2014-10-24 20:50:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ff05391561bad2a2e646be8aa46aa80a3fbc783 (presubmit successful).