Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: sky/tools/missing_from_gn

Issue 678703004: Remove a bunch of dead files found by missing_from_gn (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/text/LocaleWin.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/missing_from_gn
diff --git a/sky/tools/missing_from_gn b/sky/tools/missing_from_gn
index d8d6ebe6073e3a57689fd414630405596d09a531..fdc64d07e99c64ed77d8a96a28bb89a73d73b8f7 100755
--- a/sky/tools/missing_from_gn
+++ b/sky/tools/missing_from_gn
@@ -23,11 +23,9 @@ def stripped_lines_from_command(cmd, cwd=None):
def gn_desc(*args):
# GN doesn't understand absolute paths yet, so use a relative BUILD_DIR
# and pass ROOT_DIR as the CWD.
- cmd = [
- 'gn', 'desc',
- # Hard-coding Debug for now:
- os.path.join('out', 'Debug'),
- ] + list(args)
+ # Hard-coding Debug for now:
+ BUILD_DIR = '//out/Debug' # // means repository root-relative.
+ cmd = ['gn', 'desc', BUILD_DIR] + list(args)
return stripped_lines_from_command(cmd, cwd=ROOT_DIR)
@@ -40,7 +38,9 @@ def used_files(target):
logging.info(target)
sources = map(lambda s: s[2:], gn_desc(target, 'sources'))
inputs = map(lambda s: s[2:], gn_desc(target, 'inputs'))
- return sources + inputs
+ public = map(lambda s: s[2:], gn_desc(target, 'public'))
+ script = map(lambda s: s[2:], gn_desc(target, 'script'))
+ return sources + inputs + public + script
def find_on_disk(path):
« no previous file with comments | « sky/engine/platform/text/LocaleWin.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698