minidump/minidump_file_writer.cc - Issue 678473003: minidump: Be consistent about setting the fields of WritableIoVec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_file_writer.cc

Issue 678473003: minidump: Be consistent about setting the fields of WritableIoVec (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_file_writer.cc

diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc

index 4ee1bd07003805d78e97aa93cc8ffa7169d0920a..8e67db061232d26d36b7a8e1b895c33818088b05 100644

--- a/minidump/minidump_file_writer.cc

+++ b/minidump/minidump_file_writer.cc

@@ -150,8 +150,8 @@ bool MinidumpFileWriter::WriteObject(FileWriterInterface* file_writer) {

std::vector<WritableIoVec> iovecs(1, iov);

for (internal::MinidumpStreamWriter* stream : streams_) {

- iov.iov_len = sizeof(MINIDUMP_DIRECTORY);

iov.iov_base = stream->DirectoryListEntry();

+ iov.iov_len = sizeof(MINIDUMP_DIRECTORY);

iovecs.push_back(iov);

}

« no previous file with comments | « no previous file | minidump/minidump_memory_writer.cc » ('j') | no next file with comments »