Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3253)

Unified Diff: Source/core/svg/SVGFESpecularLightingElement.cpp

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFESpecularLightingElement.h ('k') | Source/core/svg/SVGFETileElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFESpecularLightingElement.cpp
diff --git a/Source/core/svg/SVGFESpecularLightingElement.cpp b/Source/core/svg/SVGFESpecularLightingElement.cpp
index c105238f2b179a50d51a6361ac1877e0bfbe6349..da35411fce0acc1e2faa49ae72094c19ec7dcdca 100644
--- a/Source/core/svg/SVGFESpecularLightingElement.cpp
+++ b/Source/core/svg/SVGFESpecularLightingElement.cpp
@@ -45,6 +45,16 @@ inline SVGFESpecularLightingElement::SVGFESpecularLightingElement(Document& docu
addToPropertyMap(m_in1);
}
+void SVGFESpecularLightingElement::trace(Visitor* visitor)
+{
+ visitor->trace(m_specularConstant);
+ visitor->trace(m_specularExponent);
+ visitor->trace(m_surfaceScale);
+ visitor->trace(m_kernelUnitLength);
+ visitor->trace(m_in1);
+ SVGFilterPrimitiveStandardAttributes::trace(visitor);
+}
+
DEFINE_NODE_FACTORY(SVGFESpecularLightingElement)
bool SVGFESpecularLightingElement::isSupportedAttribute(const QualifiedName& attrName)
@@ -159,7 +169,7 @@ void SVGFESpecularLightingElement::lightElementAttributeChanged(const SVGFELight
primitiveAttributeChanged(attrName);
}
-PassRefPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)
+PassRefPtrWillBeRawPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)
{
FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->currentValue()->value()));
@@ -178,7 +188,7 @@ PassRefPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilterBuilder* f
Color color = renderer->style()->svgStyle().lightingColor();
RefPtr<LightSource> lightSource = lightNode->lightSource(filter);
- RefPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, m_surfaceScale->currentValue()->value(), m_specularConstant->currentValue()->value(),
+ RefPtrWillBeRawPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, m_surfaceScale->currentValue()->value(), m_specularConstant->currentValue()->value(),
m_specularExponent->currentValue()->value(), kernelUnitLengthX()->currentValue()->value(), kernelUnitLengthY()->currentValue()->value(), lightSource.release());
effect->inputEffects().append(input1);
return effect.release();
« no previous file with comments | « Source/core/svg/SVGFESpecularLightingElement.h ('k') | Source/core/svg/SVGFETileElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698