Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: Source/core/svg/SVGElement.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGCursorElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.h
diff --git a/Source/core/svg/SVGElement.h b/Source/core/svg/SVGElement.h
index 448558f554cdb078a7a4ec554d8b7739313c15df..f96ccf529e44ff25fdbe99397e4d66907b3d9d4e 100644
--- a/Source/core/svg/SVGElement.h
+++ b/Source/core/svg/SVGElement.h
@@ -28,6 +28,7 @@
#include "core/svg/SVGParsingError.h"
#include "core/svg/properties/SVGPropertyInfo.h"
#include "platform/Timer.h"
+#include "platform/heap/Handle.h"
#include "wtf/HashMap.h"
#include "wtf/OwnPtr.h"
@@ -92,7 +93,7 @@ public:
virtual void svgAttributeChanged(const QualifiedName&);
- PassRefPtr<SVGAnimatedPropertyBase> propertyFromAttribute(const QualifiedName& attributeName);
+ PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase> propertyFromAttribute(const QualifiedName& attributeName);
static AnimatedPropertyType animatedPropertyTypeForCSSAttribute(const QualifiedName& attributeName);
void sendSVGLoadEventToSelfAndAncestorChainIfPossible();
@@ -147,7 +148,7 @@ public:
void invalidateRelativeLengthClients(SubtreeLayoutScope* = 0);
- void addToPropertyMap(PassRefPtr<SVGAnimatedPropertyBase>);
+ void addToPropertyMap(PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase>);
SVGAnimatedString* className() { return m_className.get(); }
@@ -238,7 +239,7 @@ private:
WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement> > m_elementsWithRelativeLengths;
- typedef HashMap<QualifiedName, RefPtr<SVGAnimatedPropertyBase> > AttributeToPropertyMap;
+ typedef WillBeHeapHashMap<QualifiedName, RefPtrWillBeMember<SVGAnimatedPropertyBase> > AttributeToPropertyMap;
AttributeToPropertyMap m_attributeToPropertyMap;
#if ENABLE(ASSERT)
@@ -246,7 +247,7 @@ private:
#endif
OwnPtrWillBeMember<SVGElementRareData> m_SVGRareData;
- RefPtr<SVGAnimatedString> m_className;
+ RefPtrWillBeMember<SVGAnimatedString> m_className;
};
struct SVGAttributeHashTranslator {
@@ -278,8 +279,8 @@ inline bool Node::hasTagName(const SVGQualifiedName& name) const
inline bool is##thisType(const SVGElement* element) { return element && is##thisType(*element); } \
inline bool is##thisType(const Node& node) { return node.isSVGElement() ? is##thisType(toSVGElement(node)) : false; } \
inline bool is##thisType(const Node* node) { return node && is##thisType(*node); } \
- template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { return is##thisType(node.get()); } \
- template<typename T> inline bool is##thisType(const RefPtr<T>& node) { return is##thisType(node.get()); } \
+ template<typename T> inline bool is##thisType(const PassRefPtrWillBeRawPtr<T>& node) { return is##thisType(node.get()); } \
+ template<typename T> inline bool is##thisType(const RefPtrWillBeMember<T>& node) { return is##thisType(node.get()); } \
template <> inline bool isElementOfType<const thisType>(const SVGElement& element) { return is##thisType(element); } \
DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
« no previous file with comments | « Source/core/svg/SVGCursorElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698