Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGElementRareData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 45deedc3717b3e11be82fd29e9f66aa0cc6cf2b1..85ab8628bdf6bbe6d809f33ee66f8eeb7a224b5e 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -602,7 +602,7 @@ void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& v
void SVGElement::parseAttributeNew(const QualifiedName& name, const AtomicString& value)
{
- RefPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);
+ RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);
if (property) {
SVGParsingError parseError = NoError;
property->setBaseValueAsString(value, parseError);
@@ -690,14 +690,14 @@ AnimatedPropertyType SVGElement::animatedPropertyTypeForCSSAttribute(const Quali
return AnimatedUnknown;
}
-void SVGElement::addToPropertyMap(PassRefPtr<SVGAnimatedPropertyBase> passProperty)
+void SVGElement::addToPropertyMap(PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase> passProperty)
{
- RefPtr<SVGAnimatedPropertyBase> property(passProperty);
+ RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property(passProperty);
QualifiedName attributeName = property->attributeName();
m_attributeToPropertyMap.set(attributeName, property.release());
}
-PassRefPtr<SVGAnimatedPropertyBase> SVGElement::propertyFromAttribute(const QualifiedName& attributeName)
+PassRefPtrWillBeRawPtr<SVGAnimatedPropertyBase> SVGElement::propertyFromAttribute(const QualifiedName& attributeName)
{
AttributeToPropertyMap::iterator it = m_attributeToPropertyMap.find<SVGAttributeHashTranslator>(attributeName);
if (it == m_attributeToPropertyMap.end())
@@ -902,7 +902,7 @@ void SVGElement::synchronizeAnimatedSVGAttribute(const QualifiedName& name) cons
elementData()->m_animatedSVGAttributesAreDirty = false;
} else {
- RefPtr<SVGAnimatedPropertyBase> property = m_attributeToPropertyMap.get(name);
+ RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = m_attributeToPropertyMap.get(name);
if (property && property->needsSynchronizeAttribute())
property->synchronizeAttribute();
}
@@ -1186,7 +1186,9 @@ void SVGElement::trace(Visitor* visitor)
{
#if ENABLE(OILPAN)
visitor->trace(m_elementsWithRelativeLengths);
+ visitor->trace(m_attributeToPropertyMap);
visitor->trace(m_SVGRareData);
+ visitor->trace(m_className);
#endif
Element::trace(visitor);
}
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGElementRareData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698