Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: Source/core/svg/SVGAnimatedInteger.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimatedEnumerationBase.h ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedInteger.h
diff --git a/Source/core/svg/SVGAnimatedInteger.h b/Source/core/svg/SVGAnimatedInteger.h
index 7ab3b22ca30f9afdb246de6580d60775904f7991..c6a74e9b6c66e88ac4b1c239a7570018b59773b8 100644
--- a/Source/core/svg/SVGAnimatedInteger.h
+++ b/Source/core/svg/SVGAnimatedInteger.h
@@ -33,6 +33,7 @@
#include "core/svg/SVGInteger.h"
#include "core/svg/properties/SVGAnimatedProperty.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -41,9 +42,9 @@ class SVGAnimatedIntegerOptionalInteger;
// SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedInteger
class SVGAnimatedInteger : public SVGAnimatedProperty<SVGInteger> {
public:
- static PassRefPtr<SVGAnimatedInteger> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGInteger> initialValue)
+ static PassRefPtrWillBeRawPtr<SVGAnimatedInteger> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGInteger> initialValue)
{
- return adoptRef(new SVGAnimatedInteger(contextElement, attributeName, initialValue));
+ return adoptRefWillBeNoop(new SVGAnimatedInteger(contextElement, attributeName, initialValue));
}
virtual void synchronizeAttribute() override;
@@ -53,15 +54,16 @@ public:
m_parentIntegerOptionalInteger = numberOptionalInteger;
}
+ virtual void trace(Visitor*) override;
+
protected:
- SVGAnimatedInteger(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGInteger> initialValue)
+ SVGAnimatedInteger(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGInteger> initialValue)
: SVGAnimatedProperty<SVGInteger>(contextElement, attributeName, initialValue)
- , m_parentIntegerOptionalInteger(0)
+ , m_parentIntegerOptionalInteger(nullptr)
{
}
- // FIXME: oilpan: This is kept as raw ptr as this is a back ptr. Change this to Member<> in oilpan.
- SVGAnimatedIntegerOptionalInteger* m_parentIntegerOptionalInteger;
+ RawPtrWillBeMember<SVGAnimatedIntegerOptionalInteger> m_parentIntegerOptionalInteger;
};
} // namespace blink
« no previous file with comments | « Source/core/svg/SVGAnimatedEnumerationBase.h ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698