Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/core/svg/SVGAnimatedInteger.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimatedEnumerationBase.h ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef SVGAnimatedInteger_h 31 #ifndef SVGAnimatedInteger_h
32 #define SVGAnimatedInteger_h 32 #define SVGAnimatedInteger_h
33 33
34 #include "core/svg/SVGInteger.h" 34 #include "core/svg/SVGInteger.h"
35 #include "core/svg/properties/SVGAnimatedProperty.h" 35 #include "core/svg/properties/SVGAnimatedProperty.h"
36 #include "platform/heap/Handle.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 class SVGAnimatedIntegerOptionalInteger; 40 class SVGAnimatedIntegerOptionalInteger;
40 41
41 // SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedInteger 42 // SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedInteger
42 class SVGAnimatedInteger : public SVGAnimatedProperty<SVGInteger> { 43 class SVGAnimatedInteger : public SVGAnimatedProperty<SVGInteger> {
43 public: 44 public:
44 static PassRefPtr<SVGAnimatedInteger> create(SVGElement* contextElement, con st QualifiedName& attributeName, PassRefPtr<SVGInteger> initialValue) 45 static PassRefPtrWillBeRawPtr<SVGAnimatedInteger> create(SVGElement* context Element, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGInteger> initialValue)
45 { 46 {
46 return adoptRef(new SVGAnimatedInteger(contextElement, attributeName, in itialValue)); 47 return adoptRefWillBeNoop(new SVGAnimatedInteger(contextElement, attribu teName, initialValue));
47 } 48 }
48 49
49 virtual void synchronizeAttribute() override; 50 virtual void synchronizeAttribute() override;
50 51
51 void setParentOptionalInteger(SVGAnimatedIntegerOptionalInteger* numberOptio nalInteger) 52 void setParentOptionalInteger(SVGAnimatedIntegerOptionalInteger* numberOptio nalInteger)
52 { 53 {
53 m_parentIntegerOptionalInteger = numberOptionalInteger; 54 m_parentIntegerOptionalInteger = numberOptionalInteger;
54 } 55 }
55 56
57 virtual void trace(Visitor*) override;
58
56 protected: 59 protected:
57 SVGAnimatedInteger(SVGElement* contextElement, const QualifiedName& attribut eName, PassRefPtr<SVGInteger> initialValue) 60 SVGAnimatedInteger(SVGElement* contextElement, const QualifiedName& attribut eName, PassRefPtrWillBeRawPtr<SVGInteger> initialValue)
58 : SVGAnimatedProperty<SVGInteger>(contextElement, attributeName, initial Value) 61 : SVGAnimatedProperty<SVGInteger>(contextElement, attributeName, initial Value)
59 , m_parentIntegerOptionalInteger(0) 62 , m_parentIntegerOptionalInteger(nullptr)
60 { 63 {
61 } 64 }
62 65
63 // FIXME: oilpan: This is kept as raw ptr as this is a back ptr. Change this to Member<> in oilpan. 66 RawPtrWillBeMember<SVGAnimatedIntegerOptionalInteger> m_parentIntegerOptiona lInteger;
64 SVGAnimatedIntegerOptionalInteger* m_parentIntegerOptionalInteger;
65 }; 67 };
66 68
67 } // namespace blink 69 } // namespace blink
68 70
69 #endif // SVGAnimatedInteger_h 71 #endif // SVGAnimatedInteger_h
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimatedEnumerationBase.h ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698