content/browser/download/download_file_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_file_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/base_file_unittest.cc ('k') | content/browser/download/download_manager_impl_unittest.cc » ('j') | content/browser/power_monitor_message_broadcaster_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_file_unittest.cc

diff --git a/content/browser/download/download_file_unittest.cc b/content/browser/download/download_file_unittest.cc

index dbf0fe38e8b114addc038bd99b9626b8ac3320a7..620efa36ff0e093859e17e4d23f34c19a673ca2c 100644

--- a/content/browser/download/download_file_unittest.cc

+++ b/content/browser/download/download_file_unittest.cc

@@ -125,8 +125,7 @@ class DownloadFileTest : public testing::Test {

file_thread_(BrowserThread::FILE, &loop_) {

}

- virtual ~DownloadFileTest() {

- }

+ ~DownloadFileTest() override {}

void SetUpdateDownloadInfo(int64 bytes, int64 bytes_per_sec,

const std::string& hash_state) {

@@ -139,7 +138,7 @@ class DownloadFileTest : public testing::Test {

observer_->CurrentUpdateStatus(bytes_, bytes_per_sec_, hash_state_);

}

- virtual void SetUp() {

+ void SetUp() override {

EXPECT_CALL(*(observer_.get()), DestinationUpdate(_, _, _))

.Times(AnyNumber())

.WillRepeatedly(Invoke(this, &DownloadFileTest::SetUpdateDownloadInfo));