content/browser/download/base_file_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/dom_storage/session_storage_database_unittest.cc ('k') | content/browser/download/download_file_unittest.cc » ('j') | content/browser/power_monitor_message_broadcaster_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/base_file_unittest.cc

diff --git a/content/browser/download/base_file_unittest.cc b/content/browser/download/base_file_unittest.cc

index 090e4da7b4ddfea2a1db34436622a98f05057b8b..7e27ffe0969850f4a753b573cebfe9b65a69d760 100644

--- a/content/browser/download/base_file_unittest.cc

+++ b/content/browser/download/base_file_unittest.cc

@@ -45,7 +45,7 @@ class BaseFileTest : public testing::Test {

file_thread_(BrowserThread::FILE, &message_loop_) {

}

- virtual void SetUp() {

+ void SetUp() override {

ResetHash();

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

base_file_.reset(new BaseFile(base::FilePath(),

@@ -58,7 +58,7 @@ class BaseFileTest : public testing::Test {

net::BoundNetLog()));

}

- virtual void TearDown() {

+ void TearDown() override {

EXPECT_FALSE(base_file_->in_progress());

if (!expected_error_) {

EXPECT_EQ(static_cast<int64>(expected_data_.size()),