Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 678003003: Begin to remove heap/* (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Begin to remove heap/* This makes Sky never call into the Heap::init/shutdown methods and removes most Heap:: and ThreadState:: calls throughout the rest of Sky. There is a *ton* more to remove after this. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b11d70078531570e2bbc41c92f4147a4787319e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -912 lines) Patch
M sky/engine/bindings/core/v8/V8Binding.h View 2 chunks +0 lines, -24 lines 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M sky/engine/core/Init.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationPlayerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/AnimationStackTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/animation/AnimationTimelineTest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/dom/DocumentTest.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/ElementData.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/frame/ImageBitmapTest.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 3 chunks +0 lines, -45 lines 0 comments Download
M sky/engine/platform/Supplementable.h View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/engine/platform/TaskSynchronizer.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/platform/TaskSynchronizer.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/platform/heap/Handle.h View 5 chunks +3 lines, -69 lines 0 comments Download
M sky/engine/platform/heap/Heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/platform/heap/Heap.cpp View 3 chunks +0 lines, -195 lines 0 comments Download
D sky/engine/platform/heap/HeapTerminatedArray.h View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/engine/platform/heap/HeapTerminatedArrayBuilder.h View 1 chunk +0 lines, -22 lines 0 comments Download
M sky/engine/platform/heap/ThreadState.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/platform/heap/ThreadState.cpp View 4 chunks +0 lines, -148 lines 0 comments Download
M sky/engine/platform/testing/RunAllTests.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
D sky/engine/public/web/WebHeap.h View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/Sky.cpp View 6 chunks +0 lines, -17 lines 0 comments Download
D sky/engine/web/WebHeap.cpp View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years, 1 month ago (2014-10-27 19:38:05 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-10-27 19:39:08 UTC) #3
eseidel
6 years, 1 month ago (2014-10-27 19:41:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b11d70078531570e2bbc41c92f4147a4787319e9.

Powered by Google App Engine
This is Rietveld 408576698