Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: sky/engine/platform/Supplementable.h

Issue 678003003: Begin to remove heap/* (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/BUILD.gn ('k') | sky/engine/platform/TaskSynchronizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/Supplementable.h
diff --git a/sky/engine/platform/Supplementable.h b/sky/engine/platform/Supplementable.h
index 4da76d8473389a005fdd31ef73372d4b51f0f031..a8c40869a2f8a8ccb5cc4ad401a9f732bf564d8d 100644
--- a/sky/engine/platform/Supplementable.h
+++ b/sky/engine/platform/Supplementable.h
@@ -256,12 +256,6 @@ class GC_PLUGIN_IGNORE("http://crbug.com/395036") Supplementable : public Supple
public:
virtual void trace(Visitor* visitor)
{
- // No tracing of off-heap supplements. We should not have any Supplementable
- // object on the heap. Either the object is HeapSupplementable or if it is
- // off heap it should use PersistentHeapSupplementable to trace any on-heap
- // supplements.
- COMPILE_ASSERT(!IsGarbageCollectedType<T>::value, GarbageCollectedObjectMustBeHeapSupplementable);
- SupplementableBase<T, false>::trace(visitor);
}
};
« no previous file with comments | « sky/engine/platform/BUILD.gn ('k') | sky/engine/platform/TaskSynchronizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698