Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67773002: Revert "Move innerHTML and outerHTML to Element" (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews, arv+blink, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Move innerHTML and outerHTML to Element" This patch reverts r157789 which caused: https://code.google.com/p/chromium/issues/detail?id=315842 For details, see bug. BUG=315842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -171 lines) Patch
D LayoutTests/fast/innerHTML/innerHTML-svg-read-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-svg-write-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-template-crash.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-template-crash-expected.xhtml View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-xml-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/loader/delete-inside-cancelTimer-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/script-tests/svg-attribute-length-parsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +0 lines, -46 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 7 chunks +11 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davve
7 years, 1 month ago (2013-11-09 09:17:19 UTC) #1
davve
Should only be committed if https://codereview.chromium.org/67813002 is not found acceptable. Because of timezone differences, I ...
7 years, 1 month ago (2013-11-09 13:24:35 UTC) #2
davve
7 years, 1 month ago (2013-11-10 19:45:18 UTC) #3
Message was sent while issue was closed. 
On 2013/11/09 13:24:35, David Vest wrote:
> Should only be committed if https://codereview.chromium.org/67813002 is not
> found acceptable. Because of timezone differences, I present both.

Since we're making progress in https://codereview.chromium.org/67813002, I close
this one.

Powered by Google App Engine
This is Rietveld 408576698