chrome/browser/ui/views/bookmarks/bookmark_bar_view.h - Issue 677533003: Changes BookmarkBarView to only create buttons as needed

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 677533003: Changes BookmarkBarView to only create buttons as needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: integrate feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

index 1796f136838c4dbb608bfd6f36b322c986ffd5a8..5fd88043788ed97adc3000219c4f64adb46f929d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

@@ -285,10 +285,11 @@ class BookmarkBarView : public DetachableToolbarView,

// It's easy to get the mapping wrong. For this reason all these methods are

// private.

- // Returns the number of buttons corresponding to starred urls/folders. This

- // is equivalent to the number of children the bookmark bar node from the

- // bookmark bar model has.

+ //

msw 2014/10/27 22:50:18 I don't think these two comment blocks should be j

sky 2014/10/27 23:00:49 Done.

msw 2014/10/27 23:06:00 nit: (still joined)

sky 2014/10/27 23:13:58 GAH! Sorry, misunderstood your comment. fixed.

+ // Returns the number of buttons corresponding to starred urls/folders.

+ // Buttons

msw 2014/10/27 22:50:18 What? Fix this sentence of the comment. Overall, I

sky 2014/10/27 23:00:49 Done.

+ // are lazily as necessary to fill available space. As such, the return value

+ // is often times less than that of the model.

int GetBookmarkButtonCount() const;

// Returns the button at the specified index.

« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc » ('J')